Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Respect and pass through ANDROID_USER_HOME and ANDROID_AVD_HOME" #1689

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Mar 9, 2024

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

- Clarify environment requirements for Android Gradle
- Reorder subheadings for consistency for Android and Web
@rmartin16 rmartin16 force-pushed the revert-1673-android-user-home branch from e09d4f0 to 5c93750 Compare March 9, 2024 15:58
@rmartin16
Copy link
Member Author

rmartin16 commented Mar 9, 2024

PyGObject 3.48.0 was released 2 hours ago and is failing to build/install on Fedora 39 with Python 3.12.

potentially related: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/488

@rmartin16 rmartin16 marked this pull request as ready for review March 9, 2024 17:30
@rmartin16
Copy link
Member Author

While that PyGObject issue says "installing python3-setuptools" should resolve the issue, I think it only resolves it for users not using build isolation. When I add setuptools to build-system.requires in PyGObject's pyproject.toml, only then can I build it on Fedora 39.

@rmartin16
Copy link
Member Author

@rmartin16
Copy link
Member Author

Confirmed fix in https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/302 addresses this issue.

They mentioned pushing out a new release for this....so, CI will pass once that release is out.

@rmartin16
Copy link
Member Author

And resolved with PyGObject==3.48.1 release.

@rmartin16
Copy link
Member Author

rmartin16 commented Mar 10, 2024

And now Flatpak builds are failing on PyGObject....have to look at that later...

[edit] Resolved Flatpak build issues in beeware/briefcase-linux-flatpak-template#37

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh - looks like that my "do we want to have briefcase use it's own AVD HOME" comment on the original PR turned out to be prophetic...

@freakboy3742 freakboy3742 merged commit d120c35 into main Mar 10, 2024
51 checks passed
@freakboy3742 freakboy3742 deleted the revert-1673-android-user-home branch March 10, 2024 23:39
@rmartin16
Copy link
Member Author

Heh - looks like that my "do we want to have briefcase use it's own AVD HOME" comment on the original PR turned out to be prophetic...

haha....well, not its own per se....just the same one that Android Studio would be using

Nonetheless, this means I definitely won't be able to run the emulator on that other device....although, my next limitation was RAM usage, soooo.... (and I only really cared about that since its the device I'm bringing to pycon). Running one remotely and windowless should still work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants