Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embyupdate userid config option #4883

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Conversation

shoriminimoe
Copy link
Contributor

@shoriminimoe shoriminimoe commented Aug 26, 2023

Description

Fixes #4402.

Adds a userid config option for the embyupdate plugin. When the
userid is provided, the Emby user lookup is bypassed. This avoids a
failure to get the user ID for private users.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

Adds a `userid` config option for the `embyupdate` plugin. When the
`userid` is provided, the Emby user lookup is bypassed. This avoids a
failure to get the user ID for private users.

Closes: beetbox#4402
@shoriminimoe shoriminimoe changed the title Fix 4402 Add embyupdate userid config option Aug 26, 2023
@shoriminimoe
Copy link
Contributor Author

shoriminimoe commented Aug 26, 2023

One of the original requests from #4402 was to change what is returned by get_user. I chose not to change that because that function returns the JSON object for the user from the Emby api and not just a username and ID. Instead, the user lookup is skipped entirely if a userid is supplied in the config.

@sampsyo
Copy link
Member

sampsyo commented Aug 27, 2023

Nice; this looks perfect! Many thanks!!

@sampsyo sampsyo merged commit 0e5ade4 into beetbox:master Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embyupdate: Allow direct configuration of user ID for private users
2 participants