Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slow queries for flexible attributes in aunique (fix #2678, close #3553) #4140

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

jcassette
Copy link
Contributor

@jcassette jcassette commented Nov 11, 2021

Description

This allows to use flexible attributes as aunique keys.

Example: foo%aunique{albumartist album flex,year}
Result using fast query: foo_no such column_ flex_
Result using slow query: foo [2001]

Fixes #2678
Fixes #3553

To Do

  • Documentation: not applicable
  • Changelog
  • Tests

@sampsyo
Copy link
Member

sampsyo commented Nov 11, 2021

That will do nicely; thank you! And thanks for tracking down the two different tickets (!) where we had discussed this.

@sampsyo sampsyo merged commit f3552f0 into beetbox:master Nov 11, 2021
@jcassette jcassette deleted the aunique-flexattr branch November 12, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use flexible attributes as aunique keys %aunique fails if a disambiguation is a non-fixed field
2 participants