Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beets wants to change disc order on hybrid SACDs #5148

Closed
InvisibleFunction opened this issue Mar 16, 2024 · 0 comments · Fixed by #5149
Closed

Beets wants to change disc order on hybrid SACDs #5148

InvisibleFunction opened this issue Mar 16, 2024 · 0 comments · Fixed by #5149

Comments

@InvisibleFunction
Copy link
Contributor

InvisibleFunction commented Mar 16, 2024 •
edited
Loading

Problem

I'm trying to import both layers of a hybrid SACD.

Running this command in verbose (-vv) mode:

user configuration: /Users/me/.config/beets/config.yaml
data directory: /Users/me/.config/beets
plugin paths:
inline: adding item field multidisc
fetchart: google: Disabling art source due to missing key
fetchart: lastfm: Disabling art source due to missing key
fetchart: To use Spotify as an album art source, you must install the beautifulsoup4 module. See the documentation for further details.
lastgenre: Loading canonicalization tree /Users/me/.config/beets/genres-tree.yaml
Sending event: pluginload
library database: /Users/me/.config/beets/beetsMusic.db
library directory: /Volumes/Music/Music
Sending event: library_opened
Sending event: import_begin
Sending event: import_task_created
Sending event: import_task_start
Looking up: /Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1
Tagging The Red Garland Quintet - All Mornin' Long
No album ID found.
Search terms: The Red Garland Quintet - All Mornin' Long
Additional search terms: {'label': 'Analogue Productions', 'catalognum': '', 'country': '', 'media': ''}
Album might be VA: True
Searching for MusicBrainz releases with: {'release': "all mornin' long", 'artist': 'the red garland quintet', 'tracks': '6', 'label': 'analogue productions'}
Sending event: import_task_created
Requesting MusicBrainz release 6a584522-58ea-470b-81fb-e60e5cd7b21e
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (6a584522-58ea-470b-81fb-e60e5cd7b21e)
Computing track assignment...
...done.
Success. Distance: 0.05
Requesting MusicBrainz release 03cea9b8-0469-4706-ae63-16c10dba6e43
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (03cea9b8-0469-4706-ae63-16c10dba6e43)
Computing track assignment...
...done.
Success. Distance: 0.24
Requesting MusicBrainz release b25d5905-0f14-4990-9788-6b938f39920a
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (b25d5905-0f14-4990-9788-6b938f39920a)
Computing track assignment...
...done.
Success. Distance: 0.26
Requesting MusicBrainz release efd73089-f182-4cdf-80e3-4166888b9b8e
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (efd73089-f182-4cdf-80e3-4166888b9b8e)
Computing track assignment...
...done.
Success. Distance: 0.28
Requesting MusicBrainz release bb6f46c4-bf02-4f2f-b2fd-dc9fc872dff1
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (bb6f46c4-bf02-4f2f-b2fd-dc9fc872dff1)
Computing track assignment...
...done.
Success. Distance: 0.19
Searching for MusicBrainz releases with: {'release': "all mornin' long", 'arid': '89ad4ac3-39f7-470e-963a-56509c546377', 'tracks': '6', 'label': 'analogue productions'}
Requesting MusicBrainz release 6a584522-58ea-470b-81fb-e60e5cd7b21e
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (6a584522-58ea-470b-81fb-e60e5cd7b21e)
Duplicate.
Requesting MusicBrainz release 03cea9b8-0469-4706-ae63-16c10dba6e43
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (03cea9b8-0469-4706-ae63-16c10dba6e43)
Duplicate.
Requesting MusicBrainz release 9bc87757-091a-4b52-bc84-c3b6944f73b4
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Beach Boys - All Summer Long (9bc87757-091a-4b52-bc84-c3b6944f73b4)
Computing track assignment...
...done.
Success. Distance: 0.87
Requesting MusicBrainz release b25d5905-0f14-4990-9788-6b938f39920a
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (b25d5905-0f14-4990-9788-6b938f39920a)
Duplicate.
Requesting MusicBrainz release efd73089-f182-4cdf-80e3-4166888b9b8e
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_track_extract
Sending event: mb_album_extract
Sending event: albuminfo_received
Candidate: The Red Garland Quintet - All Mornin' Long (efd73089-f182-4cdf-80e3-4166888b9b8e)
Duplicate.
Evaluating 6 candidates.
Sending event: import_task_start
fromfilename: Title replaced with: All Mornin' Long
fromfilename: Track replaced with: 1
fromfilename: Title replaced with: They Can't Take That Away From Me
fromfilename: Track replaced with: 2
fromfilename: Title replaced with: Our Delight
fromfilename: Track replaced with: 3
Looking up: /Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1/aml-wp
Tagging  -
No album ID found.
Search terms:  -
Additional search terms: {'label': '', 'catalognum': '', 'country': '', 'media': ''}
Album might be VA: True
Evaluating 0 candidates.

/Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1 (6 items)
Sending event: import_task_before_choice
Sending event: before_choose_candidate

  Match (95.4%):
  The Red Garland Quintet - All Mornin' Long
  ≠ media, year
  MusicBrainz, 2xHybrid SACD (CD layer), 2013, US, Analogue Productions, CPRJ 7130 SA, mono
  https://musicbrainz.org/release/6a584522-58ea-470b-81fb-e60e5cd7b21e
  * Artist: The Red Garland Quintet
  * Album: All Mornin' Long
  * Hybrid SACD (CD layer) 1
     ≠ (#2-1) All Mornin' Long (20:21) -> (#1-1) All Mornin' Long (20:21)
     ≠ (#2-2) They Can't Take That Away From Me (10:24) -> (#1-2) They Can't Take That Away From Me (10:27)
     ≠ (#2-3) Our Delight (6:23) -> (#1-3) Our Delight (6:23)
  * Hybrid SACD (CD layer) 2
     ≠ (#1-1) All mornin' long (20:21) -> (#2-1) All Mornin' Long (20:21)
     ≠ (#1-2) They can't take that away from me (10:27) -> (#2-2) They Can't Take That Away From Me (10:25)
     ≠ (#1-3) Our delight (6:23) -> (#2-3) Our Delight (6:23)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates?

Led to this problem:

It insists on moving all the tracks from disc 2 to disc 1 and vice versa.

$ metaflac --list --block-type=VORBIS_COMMENT 01.\ All\ mornin\'\ long.flac
METADATA block #2
  type: 4 (VORBIS_COMMENT)
  is last: false
  length: 706
  vendor string: CUETools 2.2.4
  comments: 25
    comment[0]: CTDBDISCCONFIDENCE=11/11
    comment[1]: CTDBDISCCONFIDENCE=12/12
    comment[2]: CTDBTRACKCONFIDENCE=11/11
    comment[3]: CTDBTRACKCONFIDENCE=12/12
    comment[4]: RELEASE DATE=2013
    comment[5]: RELEASECOUNTRY=US
    comment[6]: PUBLISHER=Analogue Productions
    comment[7]: LABELNO=CPRJ 7130 SA
    comment[8]: ACCURATERIPID=00061233-00135ebd-1908b903
    comment[9]: ACCURATERIPCRC=bbd53ae6
    comment[10]: ACCURATERIPDISCID=003-00061233-00135ebd-1908b903-01
    comment[11]: ACCURATERIPCOUNT=10
    comment[12]: ACCURATERIPCOUNTALLOFFSETS=10
    comment[13]: ACCURATERIPTOTAL=10
    comment[14]: CDTOC=3+A2+16691+21E8B+28ECD
    comment[15]: TRACKTOTAL=3
    comment[16]: TRACKNUMBER=01
    comment[17]: TITLE=All mornin' long
    comment[18]: ALBUM=All Mornin' Long
    comment[19]: ARTIST=Red Garland
    comment[20]: GENRE=Jazz
    comment[21]: DISCTOTAL=2
    comment[22]: DISCNUMBER=1
    comment[23]: DATE=1958
    comment[24]: COMMENT=xxx

$ ffprobe -hide_banner 01\ -\ All\ Mornin\'\ Long.dsf
[dsf @ 0x136009a00] Estimating duration from bitrate, this may be inaccurate
Input #0, dsf, from '01 - All Mornin' Long.dsf':
  Metadata:
    title           : All Mornin' Long
    artist          : The Red Garland Quintet
    track           : 1/3
    album           : All Mornin' Long
    disc            : 2/2
    date            : 2012-14-04
    genre           : Jazz
    copyright       : Analogue Productions
    publisher       : Analogue Productions
    album_artist    : The Red Garland Quintet
    PERFORMER       : The Red Garland Quintet
  Duration: 00:20:21.03, start: 0.000000, bitrate: 5644 kb/s
  Stream #0:0: Audio: dsd_lsbf_planar, 352800 Hz, stereo, fltp, 5644 kb/s

Setup

  • OS: Mac 14.3.1
  • Python version: 3.11.8
  • beets version: main
  • Turning off plugins made problem go away (yes/no):

My configuration (output of beet config) is:

(paste here)
@InvisibleFunction InvisibleFunction mentioned this issue Mar 17, 2024
Merged
2 tasks
snejus added a commit that referenced this issue Nov 23, 2024
@snejus
Fix Hybrid SACD importing (#5149)
0e6ba45 
Fixes #5148. 

When importing, the code that matches tracks does not consider the
medium number. This causes problems on Hybrid SACDs (and other releases)
where the artists, track numbers, titles, and lengths are the same on
both layers.

I added a distance penalty for mismatching medium numbers.

Before:

```
$ beet imp .

/Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1 (6 items)

  Match (95.4%):
  The Red Garland Quintet - All Mornin' Long
  ≠ media, year
  MusicBrainz, 2xHybrid SACD (CD layer), 2013, US, Analogue Productions, CPRJ 7130 SA, mono
  https://musicbrainz.org/release/6a584522-58ea-470b-81fb-e60e5cd7b21e
  * Artist: The Red Garland Quintet
  * Album: All Mornin' Long
  * Hybrid SACD (CD layer) 1
     ≠ (#2-1) All Mornin' Long (20:21) -> (#1-1) All Mornin' Long (20:21)
     ≠ (#2-2) They Can't Take That Away From Me (10:24) -> (#1-2) They Can't Take That Away From Me (10:27)
     ≠ (#2-3) Our Delight (6:23) -> (#1-3) Our Delight (6:23)
  * Hybrid SACD (CD layer) 2
     ≠ (#1-1) All mornin' long (20:21) -> (#2-1) All Mornin' Long (20:21)
     ≠ (#1-2) They can't take that away from me (10:27) -> (#2-2) They Can't Take That Away From Me (10:25)
     ≠ (#1-3) Our delight (6:23) -> (#2-3) Our Delight (6:23)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates?
```

Note that all tracks tagged with disc 1 get moved to disc 2 and vice
versa.

After:

```
$ beet-test imp .

/Volumes/Music/ti/Red Garland/1958 - All Mornin' Long - 1 (6 items)

  Match (95.4%):
  The Red Garland Quintet - All Mornin' Long
  ≠ media, year
  MusicBrainz, 2xMedia, 2013, US, Analogue Productions, CPRJ 7130 SA, mono
  https://musicbrainz.org/release/6a584522-58ea-470b-81fb-e60e5cd7b21e
  * Artist: The Red Garland Quintet
  * Album: All Mornin' Long
  * Hybrid SACD (CD layer) 1
     ≠ (#1-1) All mornin' long (20:21) -> (#1-1) All Mornin' Long (20:21)
     ≠ (#1-2) They can't take that away from me (10:27) -> (#1-2) They Can't Take That Away From Me (10:27)
     ≠ (#1-3) Our delight (6:23) -> (#1-3) Our Delight (6:23)
  * Hybrid SACD (SACD layer) 2
     * (#2-1) All Mornin' Long (20:21)
     * (#2-2) They Can't Take That Away From Me (10:24)
     * (#2-3) Our Delight (6:23)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates?
```

Yay!
@github-actions github-actions bot mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Hybrid SACD importing InvisibleFunction/beets
1 participant
@InvisibleFunction