Option to copy files atomically #3849
Comments
|
Hello! Yes, I can see this being useful as an option. Doing so would need to take some care to ensure that the temporary filename is unlikely to be confused for a complete music file. |
|
@sampsyo I guess the name |
TBH, that sounds like a bug with the indexing service. Shouldn't it detect when the file is subsequently modified (on completion of the upload) and re-index? Is this really a race condition that beet should workaround? |
|
@wisp3rwind this bug was reported to Synology also ;) But it is a good practice to make upload atomic via temp file into the same directory. For example it is the best practice when you're wirking with maildir. |
|
I think it's common to prefix temporary files with a |
|
@jackwilsdon agreed! @sampsyo any hope that it can be done? If you suggest places in the code where I need to add it, I can do it. But I scary that I may broke something :) |
|
A good place to start looking into it would be the utility functions that implement moving and copying, such as beets.util.move. |
|
@sampsyo ok, maybe I'll do it in next few days But if you can do it before, I'll be very appreciated :) |
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
|
I'd love to confirm that #4060 fixed all issues with synology indexing. |
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
The idea of this changes is simple: let move file to some temporary name inside distance folder, and after the file is already copy it renames to expected name. When someone tries to save anything it also moves file to trigger OS level notification for change FS. This commit also enforce that `beets.util.move` shouldn't be used to move directories as it described in comment. Thus, this is fixed beetbox#3849
Problem
When you importing a huge flac file to network disk via not so fast network (wifi for example) it requires a big time to complete.
If network disk has an agent that indexes files as soon as it was uploaded — for example default behaviour of Synology — it may start to index file before it is fully uploaded.
As result index will be broken.
The easy way to fix it is make inserting atomic by split it to two steps:
$realName.$someTmpPostfix$realName.$someTmpPostfixto$realNameThe text was updated successfully, but these errors were encountered: