-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholders parameters #1138
Merged
Merged
Placeholders parameters #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
=========================================
Coverage 99.68% 99.69%
- Complexity 1254 1255 +1
=========================================
Files 95 95
Lines 4836 4851 +15
=========================================
+ Hits 4821 4836 +15
Misses 15 15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a new feature to handle placeholders parameters.
Richtext editors provide already the placeholder utility: you can add BEdita object placeholders inside the rich text.
With this, you will have a list of placeholders after each richtext editor, with the possibility to set "bearing", "pitch" and "zoom" parameters.
Each object type can have its own parameters structure: you can define it using
Placeholders
configuration. For example:Bonus: this introduces
EventBus
component, that allows developers to handle global events among components.Usage: