Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct behavior of AwsS3CloudFrontAdapter, which was never invalidating anything #8

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

fquffio
Copy link
Member

@fquffio fquffio commented Aug 31, 2022

Resolves #7, among other issues introduced with #6 that caused AwsS3CloudFrontAdapter to never invalidate anything from the CloudFront distribution.

@fquffio fquffio added the bug label Aug 31, 2022
@fquffio fquffio self-assigned this Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #8 (9315ece) into master (fc507cb) will increase coverage by 4.53%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     93.25%   97.79%   +4.53%     
- Complexity       66       67       +1     
============================================
  Files             7        7              
  Lines           178      181       +3     
============================================
+ Hits            166      177      +11     
+ Misses           12        4       -8     
Impacted Files Coverage Δ
src/Filesystem/Adapter/S3Adapter.php 100.00% <ø> (ø)
src/Filesystem/Adapter/AwsS3CloudFrontAdapter.php 93.33% <100.00%> (+20.16%) ⬆️
src/Mailer/Transport/SesTransport.php 100.00% <100.00%> (ø)
src/Mailer/Transport/SnsTransport.php 100.00% <100.00%> (ø)
src/Plugin.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fquffio fquffio force-pushed the restore-cloudfront-adapter branch from 1427d61 to 9315ece Compare August 31, 2022 14:00
@fquffio fquffio mentioned this pull request Aug 31, 2022
@fquffio fquffio merged commit 1081c3c into master Aug 31, 2022
@fquffio fquffio deleted the restore-cloudfront-adapter branch August 31, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AwsS3CloudFrontAdapter possible problems in BEdita5
2 participants