fix - invalid line wrap with signed numbers in json property #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix makes sure we can identify signed numbers correctly when they are used as an object property to avoid having issues with line wrapping fixes beautifier#1932
|
@bitwiseman Did you get a chance to look at this particular PR? |
|
I hadn't. I'll take a look in the next couple days. Looks reasonable at first glance. |
bitwiseman
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main)This fix makes sure we can identify signed numbers correctly when they are used as an object property to avoid having issues with line wrapping
Fixes Issue:
fixes #1932
Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)