-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement option to support adding spaces between CSS selectors #2029
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
You'll need to resolve conflicts.
Remove selector-separator-newline
from the documented options and note it is deprecated in code comments.
I think I'd rather have the option be named selector-separator
.
Default value is "default"
. If the value is set to null
or "", the value will be treated as "default".
- If set to
"default"
andselector-separator-newline
is false, then add a space between selectors - If set to
"default"
andselector-separator-newline
is true, then add a newline between selectors - If set to anything other than
"default"
, then ignoreselector-separator-newline
and:- If set to
"none"
, then remove all whitespace between selectors. - If set to
"newline"
, then add a newline between selectors. - If set to
"space"
, then add a space between selectors. - For any other value, throw error.
- If set to
Sounds good, I'll address this soon.
To clarify, if |
No, sorry. I've updated my comment. "default" is the same as current behavior. |
Okay, just updated my changes based on your comments, including updating the README and unit tests. Let me know how it looks. |
Looks like you have some conflicts to resolve before we can run the build. |
Just resolved those conflicts👍🏼 |
Co-authored-by: Liam Newman <bitwiseman@gmail.com>
Description
main
)Fixes Issue:
Fixes #1862 - Added a new option called
selector-separator
.Added unit tests and updated the README/CLI options accordingly.
Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)