Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building on Windows #638

Closed
Xiot opened this issue Mar 8, 2015 · 2 comments
Closed

Error building on Windows #638

Xiot opened this issue Mar 8, 2015 · 2 comments
Milestone

Comments

@Xiot
Copy link
Contributor

Xiot commented Mar 8, 2015

The build script fails in a couple places while attempting to run make on windows.

Here is what I get.

Python

$ make buildp
Building python...
Obtaining file:///D:/Development/Git%20Hub/js/js-beautify/python
Requirement already satisfied (use --upgrade to upgrade): six>=1.6.1 in c:\program files\python27\lib\site-packages (from jsbeautifier==1.5.5)
Installing collected packages: jsbeautifier
  Running setup.py develop for jsbeautifier
    Creating c:\program files\python27\lib\site-packages\jsbeautifier.egg-link (link to .)
    Removing jsbeautifier 1.5.5 from easy-install.pth file
    Adding jsbeautifier 1.5.5 to easy-install.pth file
    Installing js-beautify script to C:\Program Files\Python27\Scripts
    Installed d:\development\git hub\js\js-beautify\python
Successfully installed jsbeautifier-1.5.5
$ make testp
Testing python implementation...
Python 2.7.8
./jsbeautifier/tests/shell-smoke-test.sh: line 2: $'\r': command not found
: No such file or directorysmoke-test.sh: line 4: cd: ./jsbeautifier/tests
./jsbeautifier/tests/shell-smoke-test.sh: line 5: $'\r': command not found
./jsbeautifier/tests/shell-smoke-test.sh: line 6: syntax error near unexpected token `$'\r''
'/jsbeautifier/tests/shell-smoke-test.sh: line 6: `test_cli_common()
Makefile:32: recipe for target 'testp' failed
make: *** [testp] Error 2

Javascript

$ make buildj
Building javascript...
$ make testj
Testing javascript implementation...
v0.12.0

> js-beautify@1.5.5 test D:\Development\Git Hub\js-beautify
> ./js/test/shell-smoke-test.sh

'.' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! Test failed.  See above for more details.
Makefile:39: recipe for target 'testj' failed
make: *** [testj] Error 1

I can succesfully test the javascript by running node ./js/test/node-beautify-tests.js directly

These were all run from within Cygwin

@bitwiseman
Copy link
Member

I think the error is that make on windows doesn't process the #! at the start of the file.

@Xiot
Copy link
Contributor Author

Xiot commented Mar 11, 2015

Ya, windows doesn't deal with those.
Could you move it to a js script that gets run by node and just spawn the python tests from there using something like python-shell?

@bitwiseman bitwiseman added this to the v1.6.0 milestone Mar 13, 2015
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  I don't love this but make is
not convenient on many windows machines.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  I don't love this but make is
not convenient on many windows machines.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  I don't love this but make is
not convenient on many windows machines.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  I don't love this but make is
not convenient on many windows machines.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  I don't love this but make is
not convenient on many windows machines.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  Not great but make is
not convenient on windows machines.

Bash is everywhere and our commands are not complex.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  Not great but make is
not convenient on windows machines.

Bash is everywhere and our commands are not complex.

Fixes beautifier#638
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Jan 20, 2016
Switched to a bash script for build.  Not great but make is
not convenient on windows machines.

Bash is everywhere and our commands are not complex.

Fixes beautifier#638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants