Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing: add more type annotations #203

Merged
merged 2 commits into from
Jan 8, 2025
Merged

typing: add more type annotations #203

merged 2 commits into from
Jan 8, 2025

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 6, 2025

Requires #202

@coveralls
Copy link

coveralls commented Jan 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12659814706

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.61%
Totals Coverage Status
Change from base Build 12658729373: 0.001%
Covered Lines: 1277
Relevant Lines: 1282
💛 - Coveralls

@nstarman
typing(type): add type annotations to ResolveableType and subclasses
a25f4ae 
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@nstarman nstarman changed the title typing(type): add type annotations to ResolveableType and subclasses typing(type): add type annotations to promotion objects Jan 7, 2025
@nstarman nstarman changed the title typing(type): add type annotations to promotion objects typing(type): add more type annotations Jan 7, 2025
@nstarman nstarman changed the title typing(type): add more type annotations typing: add more type annotations Jan 7, 2025
@nstarman nstarman marked this pull request as ready for review January 7, 2025 21:40
@nstarman
typing(type): add type annotations to add_promotion_rule
e99a986 
Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
@wesselb
Copy link
Member

wesselb commented Jan 8, 2025

@nstarman Thanks so much for all your work and effort! This is really great. :) Also merging this right away!

@wesselb wesselb merged commit 89831d9 into beartype:master Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nstarman @coveralls @wesselb