Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep resource client method isolated #94

Merged
merged 2 commits into from
May 1, 2017
Merged

Conversation

koriym
Copy link
Member

@koriym koriym commented May 1, 2017

class Holder extends ResourceObject
{
    public function __construct(ResourceInterface $resource)
    {
        $resource->get->uri('app://self/author?id=1')->eager->request();
    }
    public function onPost()
    {
        return true;
    }
}

When constructor has another resource request, request method was shared with two resource request client because it is injected as a singleton. This PR fix the issue.

This issue is appeared when the form which has resource request in init() injected resource client.

@koriym koriym merged commit d443a50 into bearsunday:1.x May 1, 2017
@koriym koriym deleted the spike branch May 2, 2017 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant