Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with RequiredParam handling null #285

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

jingu
Copy link
Member

@jingu jingu commented Aug 22, 2023

以下の内容を修正を行いました。

  • RequiredParamでnullを持つクエリを扱えるように変更
  • HttpAdapterが https:// で始まるURLを扱えるように変更

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e03775f) 100.00% compared to head (5581f74) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                 1.x      #285   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       508       509    +1     
===========================================
  Files             85        85           
  Lines           1362      1362           
===========================================
  Hits            1362      1362           
Files Changed Coverage Δ
src/HttpResourceObject.php 100.00% <100.00%> (ø)
src/RequiredParam.php 100.00% <100.00%> (ø)
src/SchemeCollection.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jingu added 3 commits August 22, 2023 15:28
…l_value_issue

# Conflicts:
#	src/Module/HttpClientProvider.php
#	src/Module/ImportSchemeCollectionProvider.php
#	src/Module/SchemeCollectionProvider.php
#	src/RequiredParam.php
#	tests/HttpResourceObjectTest.php
#	vendor-bin/tools/composer.lock
@jingu jingu force-pushed the fix_required_param_null_value_issue branch from 763f3e8 to 5581f74 Compare August 22, 2023 06:29
@jingu jingu marked this pull request as ready for review August 22, 2023 06:39
@koriym koriym merged commit 246016b into bearsunday:1.x Aug 22, 2023
@jingu jingu deleted the fix_required_param_null_value_issue branch August 23, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants