Merge pull request #142 from koriym/warning

E_USER_WARNING when exception caught in ResourceObject::__toString()
bearsunday · Jul 19, 2018 · c2d214c · c2d214c
2 parents adb7bd7 + 6167110
commit c2d214c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/ResourceObject.php b/src/ResourceObject.php
@@ -70,7 +70,8 @@ public function __toString()
         try {
             $view = $this->toString();
         } catch (Exception $e) {
-            trigger_error($e->getMessage() . PHP_EOL . $e->getTraceAsString(), E_USER_ERROR);
+            $msg = sprintf("%s(%s)\n%s", get_class($e), $e->getMessage(), $e->getTraceAsString());
+            trigger_error($msg, E_USER_WARNING);
 
             return '';
         }

diff --git a/tests/RequestTest.php b/tests/RequestTest.php
@@ -161,7 +161,7 @@ public function testToStringWithErrorRenderer()
             $str = $errstr;
         });
         (string) $request;
-        $this->assertSame(256, $no);
+        $this->assertSame(E_USER_WARNING, $no);
         $this->assertContains('FakeErrorRenderer->render', $str);
         $this->assertSame('', (string) $request);
         restore_error_handler();