Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all titles #11

Closed
wants to merge 1 commit into from
Closed

Conversation

rapperskull
Copy link

This should fix #10

@beandog
Copy link
Owner

beandog commented Mar 16, 2022

@rapperskull I've been debating in my head what to do on this one. I could select all of them by default, or I could add a flag to include the duplicate ones as well.

The problem is that libmpv uses TITLES_RELEVANT to get the list on a bluray. That means if someone displays all the titles / playlists on bluray_info, they're not going to necessarily match what can be done on bluray_player. The other apps would be affected because the title numbers are going to be different as well.

It looks like when running bd_select_playlist on one that is a duplicate and TITLES_RELEVANT is used in libbluray, it selects a different playlist than the one requested.

Where I'm at right now is the idea of adding the option of adding a flag to bluray_info to display duplicate titles.

@rapperskull
Copy link
Author

I think the best option is to keep TITLES_RELEVANT as the default behavior, with a flag to use TITLES_ALL. This way compatibility is preserved, while still having the ability to show all titles.

@beandog
Copy link
Owner

beandog commented Dec 4, 2023

Okay so this bug finally bit me, I found out that what libbluray decides are duplicates can change based on filesystem. I hit this initially with bd_list_titles which is using relevant as well.

This also fixes the confusion that if you look at the filesystem and there's a playlist that doesn't show up in bluray_info, running it on that missing playlist will actually switch to a completely different one.

@rapperskull thanks for bugging me about this one, you were right. :)

@beandog beandog closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some playlists not selectable / wrong playlist selected
2 participants