Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [bluray_info] Json produced by filtered output is incorrect #13

Closed
zscholl opened this issue Jan 5, 2023 · 2 comments
Closed

Comments

@zscholl
Copy link

zscholl commented Jan 5, 2023

Thank you!

First off, thank you for these amazing tools! I was using makemkv and found it to be entirely confusing and not intuitive from the command line.

I wanted to report a minor issue with json output that only seems to happen if you filter the titles. Here are the details:

Example

$ bluray_info -j > all_titles.json
$ jq . all_titles.json
... all valid json ...
$ bluray_info -M 20 -j > long_titles.json
$ jq . long_titles.json
parse error: Expected another array element at line 1504, column 2

Notes

It seems like it's adding an extra , at the end of the last title entry when it shouldn't.

vim syntax highlighting:
Screenshot 2023-01-05 at 10 12 43 AM

I've attached the two json files I generated using those commands here. They're from disc one of Cowboy Bebop. Github won't let me attach .json extensions 🙄
all_titles.txt
long_titles.txt

@zscholl zscholl changed the title [bluray_info] Json produced by filtered output is incorrect [Bug] [bluray_info] Json produced by filtered output is incorrect Jan 5, 2023
@beandog
Copy link
Owner

beandog commented May 1, 2023

Thanks for the report @zscholl! It's fixed in tree, will go out in next release.

@beandog
Copy link
Owner

beandog commented May 2, 2023

Ok 1.10 is out, let me know if you have any more problems, thanks!

@beandog beandog closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants