Issues/add missing fields #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenvanvliet
force-pushed
the
issues/add_missing_fields
branch
2 times, most recently
from
2a89996 to
0833045
Compare
maartenvanvliet
force-pushed
the
issues/add_missing_fields
branch
from
0833045 to
444ef71
Compare
snewcomer
approved these changes
Jun 9, 2019
jalexander
pushed a commit
to Frameio/stripity_stripe
that referenced
this pull request
Nov 19, 2024
jalexander
pushed a commit
to Frameio/stripity_stripe
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the tests to show which fields were still missing (see also #483 (comment))
I've added a lot of them, there are some warnings remaining but overseeable. Several of them concern deletable resources which are not mapped to a proper struct right now.
I also added the TaxID resource.