Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2018-11-08 Stripe API #439

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Dec 7, 2018

close #438

Unblock #430

@snewcomer snewcomer self-assigned this Dec 7, 2018
@snewcomer snewcomer changed the title Start resolving diffs b/w Aug and Nov stripe api changes Upgrade to Nov Stripe API Dec 27, 2018
@snewcomer snewcomer requested a review from begedin December 27, 2018 19:36
@@ -51,6 +51,7 @@ defmodule Stripe.Util do
def atomize_key(k), do: k

@spec object_name_to_module(String.t()) :: module
def object_name_to_module("file"), do: object_name_to_module("file_upload")
def object_name_to_module(object_name) do
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows us to avoid renaming Stripe.FileUpload to Stripe.File

@coveralls
Copy link

coveralls commented Dec 27, 2018

Coverage Status

Coverage increased (+0.03%) to 83.333% when pulling 77879eb on snewcomer:sn/upgrade-stripe-api into 0edafb8 on code-corps:master.

@snewcomer snewcomer force-pushed the sn/upgrade-stripe-api branch from d2dbfe6 to e17eaa4 Compare January 13, 2019 22:20
@snewcomer snewcomer changed the title Upgrade to Nov Stripe API Upgrade to 2018-11-08 Stripe API Jan 14, 2019
@snewcomer snewcomer force-pushed the sn/upgrade-stripe-api branch from e17eaa4 to 239ed39 Compare January 18, 2019 05:54
@snewcomer snewcomer force-pushed the sn/upgrade-stripe-api branch from 239ed39 to 77879eb Compare January 18, 2019 06:09
@snewcomer snewcomer merged commit 6aae1e8 into beam-community:master Jan 18, 2019
@snewcomer snewcomer deleted the sn/upgrade-stripe-api branch January 18, 2019 06:16
jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to 2018-11-08 Stripe API
2 participants