Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invoice line items support #240

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Add invoice line items support #240

merged 1 commit into from
Jul 4, 2017

Conversation

jayjun
Copy link
Contributor

@jayjun jayjun commented Jun 13, 2017

In other words, implement lines for Invoice objects.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.635% when pulling 81ea988 on jayjun:2.0-line-item into 981ff45 on code-corps:2.0.

Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Love your work @jayjun

Sorry if you felt underappreciated, but it couldn't be further from the truth.

@begedin begedin merged commit 49495f4 into beam-community:2.0 Jul 4, 2017
@jayjun
Copy link
Contributor Author

jayjun commented Jul 4, 2017

@begedin No worries mate, glad you’re back. I was more worried about the package getting abandoned, which would put my project in jeopardy.

@joshsmith
Copy link
Contributor

@jayjun definitely understand that fear, but to assuage you, there's absolutely no likelihood of that happening! We process subscriptions with this ourselves right now.

We just need your patience here and there.

The biggest frustration is currently with the testing state of the project. Merging with confidence means pretty extensive reviewing by hand, especially since we're not personally consuming some of the endpoints or use cases being added.

@jayjun
Copy link
Contributor Author

jayjun commented Jul 8, 2017

@joshsmith @begedin I understand your frustration and am following stripity_stripe_testing. Don’t get me wrong, I personally appreciate your efforts so far.

For my company to trust it in production however would require active development, including supporting 1.x until 2.0 is ready. High-level 2.0 discussions look promising, but they fall silent for months. Stripe’s API is a moving target, with 5 version bumps this year so far.

I try to contribute where I can but that seems to compound the problem. Those pull requests are things we (and others) desperately need in production. We simply rather use another actively maintained library than maintain a fork of an inactive one.

So it’s not a matter of patience, but practicality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants