Add functions to update managed accounts

[nkezhaya]

Made a new pull request. This is actually on a feature branch as opposed to master, and it takes into account the new repository name.

[coveralls]

Coverage increased (+0.2%) to 78.049% when pulling da3c82a on whitepaperclip:update-accounts into e35cd0f on code-corps:master.

[joshsmith]

@whitepaperclip what appears to be failing here is something like the assertions from ex_unit's own tests https://github.com/elixir-lang/elixir/blob/master/lib/ex_unit/test/ex_unit/assertions_test.exs#L650-L655

It looks like flunk is not being provided a binary for some reason. If this passes locally, would you be able to push up something with an IO.inspect err or something so we can see the output on CI?

[nkezhaya]

It doesn't pass locally, but here's the error:

%{"error" => %{"message" => "The provided key '********************' does not have access to account 'acct_**' (or that account does not exist). Application access may have been revoked.", "type" => "invalid_request_error"}}

[nkezhaya]

Ah, that's the error that shows up in fixture/vcr_cassettes/account_test/update.json and update_with_key.json. The account should probably be created first.

[joshsmith]

Ah, I'm not familiar with the old testing strategy used here other than with VCR generally from Rails-land. Is there a cassette that actually matches this request?

[joshsmith]

@whitepaperclip my last comment was made at about the same time as yours, I think. Didn't see it before. We'll need to update the cassettes for it to pass.

[begedin]

@whitepaperclip Hey! Thanks for your work. It looks like our vcr tapes need updating and that's the main issue with tests failing. I'm currently working on that as part of this PR. I'll let you know when I get it done.

[begedin]

Copying from the other PR:

My commit fixes the broken tests. It also makes me realize that our existing testing which relies on VCR is very flaky and probably needs work. I will create an issue where we can discuss and address this.

Just to document what I ultimately did here, after a lot of experimenting and figuring things out:

• Deleted all vcr tapes under the account folder
• Re-ran the test suite using a --seed 0 command argument (so the tests run in order, because our test suite is that fragile).

Also I added a filter for sensitive data, so the newly recorded tapes do not expose our secret key. Our other pre-recorded tapes still do so, so we need to fix that asap

[begedin]

This looks good to go, as far as I'm concenred. Feel free to squash into one commit and merge.

Scratch that, something went wrong. Looking into it.

[nkezhaya]

Seems to be passing now!

[begedin]

Review is still there, so feel free to squash and merge when ready.

[joshsmith]

@whitepaperclip thanks for bearing with us on this, and 🙌 to @begedin for this fix.

[joshsmith]

Also 🙌 @whitepaperclip for the PR! 🙌 all around