Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Elixir Requirement to >= 1.4.0 #277

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Bump Elixir Requirement to >= 1.4.0 #277

merged 1 commit into from
Jun 15, 2018

Conversation

dbernheisel
Copy link
Contributor

@dbernheisel dbernheisel commented Mar 13, 2018 •
edited
Loading

Because we use List.pop_at from #227, we require the project to run with Elixir 1.4.0 or higher. This reports ex_machina correctly. List.pop_at was introduced in Elixir 1.4.0

@dbernheisel dbernheisel mentioned this pull request Mar 13, 2018
Merged
germsvel
germsvel approved these changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@germsvel germsvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@germsvel germsvel merged commit 4d1cb60 into master Jun 15, 2018
@germsvel germsvel deleted the db-bump-req-to-elixir-1-4 branch June 15, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germsvel germsvel germsvel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbernheisel @germsvel