Feature/navgation body builder #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we be using |
|
I don't think so, we are using a building pattern anyway in the class by only building the widget at the current index. A listview builder does not make sense here |
bdlukaa
approved these changes
Oct 3, 2021
WinXaito
pushed a commit
to WinXaito/fluent_ui
that referenced
this pull request
Nov 28, 2021
dev-hann
added a commit
to dev-hann/fluent_ui
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a builder variant to NavigationBody. Fixes #76
Pre-launch Checklist
dartfmton all changed filesCHANGELOG.mdwith my changesflutter pub publish --dry-runand addressed any warnings