Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Flutter 3.0.0 #325

Merged
merged 3 commits into from
May 13, 2022
Merged

Build on Flutter 3.0.0 #325

merged 3 commits into from
May 13, 2022

Conversation

h3x4d3c1m4l
Copy link
Contributor

Fixes build on Flutter 3.0.0 including any new warnings. Basic functionality tested using my mobile app.

I tried finding a way to have it compiling on both Flutter < 3.0.0 and Flutter 3.0.0 but it seems Dart does not support preprocessing like many C style languages... If anyone knows a way let me know and I'll happily adapt my PR.

Therefore this does break building on Flutter < 3.0.0.

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@bdlukaa
Copy link
Owner

bdlukaa commented May 11, 2022

If ? is used where ! previously were, there probably will be backwars compatibility

@bdlukaa
Copy link
Owner

bdlukaa commented May 12, 2022

@h3x4d3c1m4l tests are failing :/

@grahamsmith
Copy link

@bdlukaa - It might be wise given this was a major release to spin up a pre-release and new major version here to help with the compatibility? I saw similar approaches when moving to not null etc.

Gives people chance to move over to Flutter 3.0 and then eventually it can be the main release etc.

Awesome work on this project. It looks and feels wonderful.

@grahamsmith
Copy link

The failing tests look easier to fix - I could always PR into this PR 😂

@h3x4d3c1m4l
Copy link
Contributor Author

Fixed the warnings by removing the unused private code. Looking at backwards compatibility right now.

@bdlukaa bdlukaa merged commit e9d92a8 into bdlukaa:master May 13, 2022
@bdlukaa bdlukaa mentioned this pull request May 13, 2022
1 task
@h3x4d3c1m4l
Copy link
Contributor Author

h3x4d3c1m4l commented May 13, 2022

I see you merged it already :) Nice!

Will open another one to upgrade flutter_lints and to fix the 74 new warnings. Also I looked at the possibilities for backwards compatibility.

But unfortunately, as Dart does not have any C language style preprocessing and conditional imports do not seem to be suitable (they don't support Flutter version as a condition), I can't find a way to have it backwards compatible.

@h3x4d3c1m4l h3x4d3c1m4l deleted the bugfix/flutter_3.0.0 branch May 13, 2022 17:25
@bdlukaa
Copy link
Owner

bdlukaa commented May 13, 2022

@h3x4d3c1m4l don't worry about flutter_lints, I'm already on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrading to Flutter 3.0 I can't run applications with fluent_ui🐛
3 participants