-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on Flutter 3.0.0 #325
Conversation
If |
@h3x4d3c1m4l tests are failing :/ |
@bdlukaa - It might be wise given this was a major release to spin up a pre-release and new major version here to help with the compatibility? I saw similar approaches when moving to not null etc. Gives people chance to move over to Flutter 3.0 and then eventually it can be the main release etc. Awesome work on this project. It looks and feels wonderful. |
The failing tests look easier to fix - I could always PR into this PR 😂 |
Fixed the warnings by removing the unused private code. Looking at backwards compatibility right now. |
I see you merged it already :) Nice! Will open another one to upgrade flutter_lints and to fix the 74 new warnings. Also I looked at the possibilities for backwards compatibility. But unfortunately, as Dart does not have any C language style preprocessing and conditional imports do not seem to be suitable (they don't support Flutter version as a condition), I can't find a way to have it backwards compatible. |
@h3x4d3c1m4l don't worry about flutter_lints, I'm already on that |
Fixes build on Flutter 3.0.0 including any new warnings. Basic functionality tested using my mobile app.
I tried finding a way to have it compiling on both Flutter < 3.0.0 and Flutter 3.0.0 but it seems Dart does not support preprocessing like many C style languages... If anyone knows a way let me know and I'll happily adapt my PR.
Therefore this does break building on Flutter < 3.0.0.
Pre-launch Checklist
CHANGELOG.md
with my changes