Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link (anchor) for Info Label #285

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Fix link (anchor) for Info Label #285

merged 2 commits into from
Apr 12, 2022

Conversation

WinXaito
Copy link
Collaborator

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have added/updated relevant documentation

@WinXaito WinXaito requested a review from bdlukaa April 12, 2022 15:12
@bdlukaa
Copy link
Owner

bdlukaa commented Apr 12, 2022

InfoBadge and InfoLabel are two different things.

InfoLabel:

InfoBadge:

I believe you wanted to fix the https://github.com/bdlukaa/fluent_ui#info-header, which is not working :/

@WinXaito
Copy link
Collaborator Author

I need a holiday, I change one line and make a mistake... Nice catch

@bdlukaa bdlukaa merged commit ad166a0 into bdlukaa:master Apr 12, 2022
@WinXaito WinXaito deleted the fix_readme branch April 12, 2022 18:14
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WinXaito @bdlukaa