Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear button autosuggest #240

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Clear button autosuggest #240

merged 3 commits into from
Mar 25, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Mar 24, 2022

Fixes #238
Updates TextBox colors

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have added/updated relevant documentation

@henry2man
Copy link
Contributor

henry2man commented Mar 25, 2022

#238 (comment)

@bdlukaa Although I have also had this issue I have seen another that may be related. When an element is chosen from the drop-down list, a change of type TextChangedReason.suggestionChosen is NOT being generated; instead TextChangedReason.userInput is always sent

Also, in the future we should consider enrich the current AutoSuggestBox with generics. I was trying to replace a Combobox<T?> with an AutoSuggestBox (where T? is a complex type) but this implies a lot of String <-> T? conversions without native support.

EDIT: I've opened #244 for further discussion about the later.

@bdlukaa bdlukaa merged commit 41df78a into master Mar 25, 2022
@bdlukaa bdlukaa deleted the clear-button-autosuggest branch March 25, 2022 19:09
@shunsen
Copy link

shunsen commented Jun 24, 2022

there ia a problem described in the bug #238 and it is still exists now;
described:When clicking the clear button the onPressed callback is never called.
expected:after click on the newly appeared clear button on the right of the field, the callback function onSelect or onChanged should be called , maybe we can treat the empty string as a usable value

dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 AutoSuggestBox clear button does not work
3 participants