Optional content for Expander #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasht
changed the title
bdlukaa
reviewed
Mar 24, 2022
| @@ -198,6 +198,52 @@ class ExpanderState extends State<Expander> | |||
| Widget build(BuildContext context) { | |||
| assert(debugCheckHasFluentTheme(context)); | |||
| theme = FluentTheme.of(context); | |||
| if (widget.content == null) { | |||
There was a problem hiding this comment.
Would this be some boilerplate code? Isn't it better to check if content is null on SizeTransition?
There was a problem hiding this comment.
You might be right, but I haven't used SizeTransition before. Would the use of SizeTransition still hide the handle and prevent any actions on the object? (Hover color etc)
|
I think this would fix #220. |
|
I don't like the idea of this. It'd be better to re-style |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the
contentparameter optional forExpander. AnExpanderwith no content will not be able to be expanded, but will still have the same theming as the a regularExpanderPre-launch Checklist
CHANGELOG.mdwith my changes