Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumberBox widget #212

Closed
wants to merge 3 commits into from
Closed

Conversation

WinXaito
Copy link
Collaborator

@WinXaito WinXaito commented Mar 4, 2022

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

Compact mode:

numberbox_compact

Inline mode:

numberbox_inline

@WinXaito WinXaito marked this pull request as draft March 4, 2022 14:18
@bdlukaa
Copy link
Owner

bdlukaa commented Mar 6, 2022

When the controller value is changed, the text selection cursor should be changed to the end instead of being at the start

@WinXaito
Copy link
Collaborator Author

WinXaito commented Mar 7, 2022

I really have no idea how to do it.

numberbox_compact

The overlay must be present, when textbox have focus (and when overlay is open, the focus must stay on textbox !) and textbox must be editable when overlay is open.

So, with the dropdown overlay solution, when the overlay is open the focus on textbox is lost and nothing stay editable...

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 13, 2022

@WinXaito IconButton requests focus everytime the user pressed the button. You can create your own button that do not request focus. Also, you can use a FocusNode to request the focus back to the text box if it's by any mean lost

@WinXaito WinXaito mentioned this pull request Oct 4, 2022
@ricardoboss
Copy link

@WinXaito are you planning on completing this?

@WinXaito
Copy link
Collaborator Author

Yup, but I don't know when.

I checked this today. I think that will be simpler with the new Flyout rework. I will try to take a look on that this week.

@bdlukaa
Copy link
Owner

bdlukaa commented Mar 13, 2023

EditableComboBox may be similar to this

@WinXaito
Copy link
Collaborator Author

Closing in favor of #771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants