Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors update #201

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Colors update #201

merged 6 commits into from
Feb 25, 2022

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented Feb 24, 2022

See #111
Fixes #174
Fixes #200

Changes

  • Added cardColor and menuColor to ThemeData
  • Implemented Card
  • Exposed more properties to auto suggest box

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@bdlukaa bdlukaa requested a review from WinXaito February 24, 2022 17:08
WinXaito
WinXaito reviewed Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@WinXaito WinXaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a light accent color, all widget are black
image

But with a darker accent color, there are differences between the widgets
image

lib/src/controls/form/combo_box.dart
// (double total, double height) => total + height);
// final bool isScrollable =
// _kListPadding.vertical + menuTotalHeight >
// constraints.maxHeight;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete these comment if not used ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be used in the future!

@WinXaito
Copy link
Collaborator

With the dark infobar, we have a strange effect. (like he's come bigger) But it's probably because the color change is more important than light theme.
info_bar_dark

That we doesn't have with light theme
info_bar_light

@bdlukaa
Copy link
Owner Author

bdlukaa commented Feb 25, 2022

But with a darker accent color, there are differences between the widgets

That's on purpose!

@bdlukaa bdlukaa merged commit 1f0126d into master Feb 25, 2022
@bdlukaa bdlukaa deleted the colors-update branch February 25, 2022 17:23
@WinXaito
Copy link
Collaborator

But with a darker accent color, there are differences between the widgets

That's on purpose!

Ok for the button, but does the checkbox be different than Switch ? (I didn’t check on Microsoft docs)

@bdlukaa
Copy link
Owner Author

bdlukaa commented Feb 25, 2022

@WinXaito for checkbox, the contrast color is applied

@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
Colors update (bdlukaa#201)
85b07e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WinXaito WinXaito WinXaito left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 FilledButton doesn't have Hover animation Provide more customization options to AutoSuggestBox
2 participants
@bdlukaa @WinXaito