Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComboBox borders #129

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Fix ComboBox borders #129

merged 3 commits into from
Jan 11, 2022

Conversation

alesimula
Copy link
Contributor

ComboBox borders are not actually rounded (although black rounded borders are drawn, the Acrylic widget had no border radius)

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@alesimula
Fix ComboBox borders
04ebe27 
ComboBox borders are not actually rounded (although black rounded borders are drawn, the Acrylic widget had no border radius)
@bdlukaa
Copy link
Owner

bdlukaa commented Jan 11, 2022

Could you update the changelog please?

@alesimula
Copy link
Contributor Author

@bdlukaa done

@bdlukaa bdlukaa merged commit 6eb800e into bdlukaa:master Jan 11, 2022
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
Fix ComboBox borders (bdlukaa#129)
2b4d9db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesimula @bdlukaa