source release hashes: only sha512. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemers
approved these changes
Mar 4, 2022
|
@bmarwell you don't even need old md5 and sha1 on the Apache distribution area https://dlcdn.apache.org/shiro/ (which will be archived to https://archive.apache.org/dist/shiro/ ) (md5 and sha1 are the checksums on Maven Central, which has completely different rules/prerequisites) |
|
and you'll need to add sha512 for old releases, like in https://archive.apache.org/dist/shiro/1.1.0/ for example |
bmarwell
changed the title
bmarwell
force-pushed
the
source-release-hashes
branch
from
f1bf838
to
09f73d7
Compare
|
Done! Thanks for the hints! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking to @hboutemy, only sha512 is really important for source release zip files.
After apache/shiro#349 and apache/shiro-site#152, let's simplify this script again.