Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N/A] Expose height in Spot_Wrapper velocity command #147

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

fgillespie-bdai
Copy link
Contributor

@fgillespie-bdai fgillespie-bdai commented Oct 17, 2024

Change Overview

This change enables dynamic height changes for teleop during the Drive-A-Spot demo. It adds an optional body_height parameter for the velocity_cmd function in Spot Wrapper.

Testing Done

This change has been tested on Spot.

Instructions for Reviewers

  • Certify that this change is following our dependency rules.
  • Certify that the author has filled in the testing section with appropriate testing:
    • Spot testing for PRs touching Spot functionality, including the list of functions tested.
    • Open AI testing for PRs touching code that calls Open AI functions, including a list of tests done. For example, did they test dry, canned, AND online?
    • ROS 2 testing for PRs that use ROS 2 and that their ROS 2 tests use the domain_coordinator to prevent port conflicts.
  • For changes to docker, take a look at docker testing

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fgillespie-bdai and the rest of your teammates on Graphite Graphite

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11391430677

Details

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 40.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spot_wrapper/wrapper.py 1 4 25.0%
Totals Coverage Status
Change from base Build 11386831056: -0.01%
Covered Lines: 1869
Relevant Lines: 4577

💛 - Coveralls

@fgillespie-bdai fgillespie-bdai force-pushed the fgillespie/expose_spot_height branch 3 times, most recently from fb5b870 to 72a85a2 Compare October 17, 2024 19:04
@fgillespie-bdai fgillespie-bdai force-pushed the fgillespie/expose_spot_height branch from 72a85a2 to 186ab04 Compare October 17, 2024 19:08
Copy link
Collaborator

@tcappellari-bdai tcappellari-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor Author

fgillespie-bdai commented Oct 18, 2024

Merge activity

  • Oct 18, 1:38 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 18, 1:41 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Oct 18, 1:43 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 18, 1:47 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason.
  • Oct 18, 1:48 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 18, 1:48 PM EDT: A user merged this pull request with Graphite.

@khughes-bdai khughes-bdai merged commit 61c2574 into main Oct 18, 2024
3 checks passed
@khughes-bdai khughes-bdai deleted the fgillespie/expose_spot_height branch October 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants