-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N/A] Expose height in Spot_Wrapper velocity command #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fgillespie-bdai and the rest of your teammates on Graphite |
Pull Request Test Coverage Report for Build 11391430677Details
💛 - Coveralls |
fgillespie-bdai
force-pushed
the
fgillespie/expose_spot_height
branch
from
October 17, 2024 18:00
368ec19
to
401a09a
Compare
fgillespie-bdai
requested review from
jbarry-bdai,
heuristicus,
amessing-bdai,
khughes-bdai and
tcappellari-bdai
as code owners
October 17, 2024 18:06
khughes-bdai
approved these changes
Oct 17, 2024
fgillespie-bdai
force-pushed
the
fgillespie/expose_spot_height
branch
3 times, most recently
from
October 17, 2024 19:04
fb5b870
to
72a85a2
Compare
fgillespie-bdai
force-pushed
the
fgillespie/expose_spot_height
branch
from
October 17, 2024 19:08
72a85a2
to
186ab04
Compare
tcappellari-bdai
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This change enables dynamic height changes for teleop during the Drive-A-Spot demo. It adds an optional body_height parameter for the velocity_cmd function in Spot Wrapper.
Testing Done
This change has been tested on Spot.
Instructions for Reviewers
domain_coordinator
to prevent port conflicts.