Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to N-API and deprecate NAN #38

Closed
braydonf opened this issue Dec 26, 2019 · 4 comments
Closed

Switch to N-API and deprecate NAN #38

braydonf opened this issue Dec 26, 2019 · 4 comments

Comments

@braydonf
Copy link
Contributor

Is the use of NAN still necessary with N-API?

The bdb package does not depend on NAN with the use of N-API.
@chjj
Copy link
Member

chjj commented Jan 27, 2020

It would be really nice to get away from NAN, but it seems like it would be a huge rewrite. I think it might be extra difficult since it may be hard to do incrementally (?).

@braydonf
Copy link
Contributor Author

braydonf commented Feb 3, 2020

Yeah, all of ./src/ would need to be updated to use N-API patterns instead of NAN. This may be able to be done per module, however once new pattern established it'll likely be quicker to update the others.

@braydonf
Copy link
Contributor Author

Related pull request for libsecp256k1 bindings cryptocoinjs/secp256k1-node#160

chjj added a commit that referenced this issue Mar 14, 2020
@chjj
src: initial port to n-api. see #38.
e94f56d
@braydonf
Copy link
Contributor Author

Looks like this has been implemented on the master branch now (nan is no longer a dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chjj @braydonf