Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain: refactor deployments, pow target #103

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

tuxcanfly
Copy link
Member

Minor refactor to match reference implementation in pow target, deployments.

Refs: https://reviews.bitcoinabc.org/rABCd011b78672

@tuxcanfly tuxcanfly requested a review from nodech November 13, 2018 08:26
@codecov-io
Copy link

codecov-io commented Nov 13, 2018

Codecov Report

Merging #103 into master will increase coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   55.46%   55.47%   +<.01%     
==========================================
  Files         109      109              
  Lines       27162    27169       +7     
  Branches     4496     4496              
==========================================
+ Hits        15066    15071       +5     
- Misses      12096    12098       +2
Impacted Files Coverage Δ
lib/blockchain/chain.js 62.52% <77.77%> (+0.23%) ⬆️
lib/coins/compress.js 55.06% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485a79d...0f3b085. Read the comment docs.

Copy link
Member

@nodech nodech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! LGTM

@tuxcanfly tuxcanfly merged commit 720f353 into bcoin-org:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants