Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor repeating code #11

Merged
merged 4 commits into from
Jun 5, 2016
Merged

refactor repeating code #11

merged 4 commits into from
Jun 5, 2016

Conversation

batuhan
Copy link
Collaborator

@batuhan batuhan commented Jun 4, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 97.849% when pulling 1189d5f on batuhan:es6 into 5249246 on bcoe:master.

@bcoe
Copy link
Owner

bcoe commented Jun 4, 2016

@batuhan I really like the cleanup of pushing the providers into a list 👍

I usually try to make sure that any tools I write work all the way back to Node 0.10, since folks installing the tool who aren't Node affianodos are often running older platforms.

tldr; perhaps update this patch to include your refactor without the ES2015 constructs.

@batuhan
Copy link
Collaborator Author

batuhan commented Jun 4, 2016

I've updated the es6 branch to not include es6 :)

So, just added the checker generator thingy.

There seems to be problem with the whois fallback with my updates. I'm checking it right now.

@coveralls
Copy link

coveralls commented Jun 4, 2016

Coverage Status

Coverage decreased (-0.1%) to 97.849% when pulling 669447b on batuhan:es6 into 5249246 on bcoe:master.

@bcoe
Copy link
Owner

bcoe commented Jun 4, 2016

@batuhan looks good to me, coverage just dropped because you reduced the lines of code with cleanup.

any reason not to land this?

@bcoe bcoe changed the title converted the main code to ES6 & deleted repeating code refactor repeating code Jun 5, 2016
@bcoe bcoe merged commit 99b6ca0 into bcoe:master Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants