Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: taiko #559

Merged
merged 6 commits into from
Aug 15, 2024
Merged

fix: taiko #559

merged 6 commits into from
Aug 15, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Aug 13, 2024

PR-Codex overview

This PR updates the version to 4.6.1, fixes Taiko testnet, adds test-playground workflow, and refactors code in various files.

Detailed summary

  • Version bumped to 4.6.1, Taiko testnet fix
  • Added test-playground workflow
  • Refactored code in BaseSmartContractAccount
  • Updated constants in Constants.ts
  • Added taikoHekla chain in tests
  • Updated code in write.test.ts and playground/write.test.ts

The following files were skipped due to too many changes: tests/playground/write.test.ts, src/account/BiconomySmartAccountV2.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
core (esm) 72.52 KB (0%)
core (cjs) 78.39 KB (0%)
account (tree-shaking) 69.8 KB (0%)
bundler (tree-shaking) 2.54 KB (0%)
paymaster (tree-shaking) 2.23 KB (0%)
modules (tree-shaking) 57.85 KB (0%)

@joepegler joepegler merged commit bdb32a0 into develop Aug 15, 2024
5 checks passed
@joepegler joepegler deleted the feat/taiko branch August 15, 2024 09:28
@livingrockrises
Copy link
Contributor

sorry @joepegler I missed to review.
but I prefer to change name and constants from Taiko to Taiko_Hekla please?
TAIKO_FACTORY_ADDRESS > TAIKO_HEKLA_FACTORY_ADDRESS and such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants