Feat/devx 362 abstract required bundler #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmanRaj1608
reviewed
Dec 22, 2023
AmanRaj1608
approved these changes
Dec 22, 2023
|
can you please resolve the conflicts |
| @@ -89,6 +88,14 @@ type ConditionalValidationProps = RequireAtLeastOne< | |||
| "defaultValidationModule" | "signer" | |||
| >; | |||
|
|
|||
| type ConditionalBundlerProps = RequireAtLeastOne< | |||
There was a problem hiding this comment.
I see you already have conditional props. would there be a case when bundler is not used at all?
if someone is using only paymaster service for estimations and just building userops.
@AmanRaj1608
There was a problem hiding this comment.
As we discussed yesterday, I believe bundler should be required as you cannot do much without it and it will also help us to abstract things like chain id in the future. Clients that currently create smart accounts without bundler will need to update the codebase.
There was a problem hiding this comment.
we should mention this in the docs after release
…into feat/DEVX-362-Abstract-Required-Bundler
livingrockrises
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Abstracted the need for the client to create an instance of Bundler and assign it to the smart account.
Added a light way of assigning a Bundler by just providing a "bundlerUrl" param.
Change Type
Checklist