buildUserOp: force encode for batch #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,12 +312,18 @@ export class BiconomySmartAccountV2 extends BaseSmartAccount { | |||
| const data = transactions.map((element: Transaction) => element.data ?? '0x') | |||
| const value = transactions.map((element: Transaction) => element.value ?? BigNumber.from('0')) | |||
|
|
|||
| if (transactions.length === 0) { | |||
There was a problem hiding this comment.
Check for undefined value of transactions should be added as well.. Better to add an internal validation function and do all validation checks there..
There was a problem hiding this comment.
will handle this in error handling sweep PR
tomarsachin2271
approved these changes
Sep 11, 2023
AmanRaj1608
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in buildUserOp even if transactions array length is 1, for some validation modules optionally devs want to encode it for executeBatch. optional flag is added which achieves this
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: