Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/sma 86 code style #280

Merged

Conversation

Aboudjem
Copy link
Contributor

@Aboudjem Aboudjem commented Sep 8, 2023

Description

Improved code style, lint, security and added Airbnb lint configurations to enhance the code quality and maintainability. These changes aim to align the project with best practices and ensure a consistent coding style across the codebase.

Fixes #SMA-86

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

@Aboudjem Aboudjem self-assigned this Sep 8, 2023
@linear
Copy link

linear bot commented Sep 8, 2023

SMA-86 Add linting and code style config

Github Repo: https://github.com/bcnmy/biconomy-client-sdk

Add standard linting rules and code style config (eg prettier) in the repository.

All linting and style rules should be run on each PR as part of CI pipeline and if any rule fails, PR should not be merged.

@Aboudjem Aboudjem changed the base branch from development to features/SMA-81-testing-framework September 8, 2023 11:23
Copy link
Contributor

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@livingrockrises livingrockrises merged commit f02c6c4 into features/SMA-81-testing-framework Sep 11, 2023
@Aboudjem Aboudjem deleted the features/SMA-86-code-style branch September 11, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants