Adding Session Storage Interface #256
Conversation
SMA-60 Add session storage feature in the sdk
Add classes related to session storage with support for local storage initially and then later remote storage at some persistent storage as well. |
|
A method to reset the state can be added, but when will the client call this method? I hope this will be checked by the implementation of session storage interface which will check this matching of merkle root in storage with on-chain data |
| sessionValidationModule: string | ||
| sessionKeyData: string | ||
| signerPublicKey: string | ||
| sessionID: string |
There was a problem hiding this comment.
would this not be optional?
| validAfter: number | ||
| sessionValidationModule: string | ||
| sessionKeyData: string | ||
| signerPublicKey: string |
There was a problem hiding this comment.
can we rename to sessionPublicKey
| status: SessionStatus | ||
| } | ||
|
|
||
| export type SessionSearchParam = { |
There was a problem hiding this comment.
from where we will get scw address information?
yesterday we discussed scw address, session validation module address and session pubkey will give a unique leaf.
but not just scw address and validation module address - as there may be two different session pub keys active in different browser for the same user for same session.
There was a problem hiding this comment.
When user will create an instance of SessionLocalStorage then in that constructor user will pass SCW address and the json data that'll be stored in the storage will be against that scw address.
So if user uses a different SCW address tomorrow, then a new key and data will be created in local storage for that user. You'll see once you see the implementation of this interface.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: