-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK v2 fixes #241
SDK v2 fixes #241
Conversation
fix: avoid sending populated values of gas prices when estimating
verify account deployment even when nonce is 0
finalUserOp replaced with userOp for overrides proper usage
Publish alpha.1
try { | ||
finalUserOp = await this.estimateUserOpGas(finalUserOp) | ||
const cgl = ethers.BigNumber.from(finalUserOp.callGasLimit) | ||
if (finalUserOp.callGasLimit && cgl.lt(ethers.BigNumber.from('21000'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we are adding this if statement ?
if (finalUserOp.callGasLimit && cgl.lt(ethers.BigNumber.from('21000')))
should not we just update finalUserOp callData with newCallData before calling estimateUserOpGas ?
finaluserOp.callData = newCallData
finalUserOp = await this.estimateUserOpGas(finalUserOp)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its already updated above then sent for estimation. If estimation still returns less cgl then send earlier op with updated calldata.
Since we are not introducing any new features, only providing minor bug fixes and small changes, we should update the last number in the versioning scheme i.e 3.0.1. This last number represents the "patch" number and is used for minor updates that address issues without adding new features or major changes. |
reviewed and it LGTM. added few comments as well |
hence it's a prepatch |
Description
fixes userop gaslimit issues : #236
and for polygon / other chains with undeployed accounts
fixes AA10 issue
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: