Converted to walk function instead of a RuleWalker #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
reviewed
Aug 20, 2018
| import * as ts from 'typescript'; | ||
|
|
||
| interface Options { | ||
| /** @internal */ |
There was a problem hiding this comment.
Yeah I was a little confused how to represent this. It's not common for the interface Options on a rule to be different from the config the rule is allowed to take in.
@internal is recognized by TS and seems to be coming up as part of TSDoc, so I figured it was appropriate here. If you change or remove this I won't be offended at all 😉
bcherny
requested changes
Aug 20, 2018
|
|
||
| context.addFailureAt(node.getStart(), node.getWidth(), Rule.FAILURE_STRING + ": " + maybeCycle | ||
| .concat(fileName) | ||
| .map(x => relative(context.options.rootDir, x)) |
bcherny
approved these changes
Aug 20, 2018
|
Thanks @JoshuaKGoldberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21