-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file action feature #32
Conversation
Hi, Thanks for your contribution. Can you please add a screenshot of the workflow? |
src/fileAction.js
Outdated
const query = alfy.input; | ||
|
||
// output | ||
console.log(product.binPath + ' "' + query + '"'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's more clean if we use alfy.output
and create an "item". What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but utilising alfy.output
actually complicate things,
link output function will nest my only item
in an array, which I need to access it through zsh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchatard can you show me the better example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you output the same format as "standard" workflow, you can reuse the existing run script, no?
If yes, your previous commit with the export of buildItem
is a good way to achieve this. And also fix the missing notification.
(a lot of guessing on this, I'm not really available for more debugging on this actually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, agree, currently the Notification does not show proper message. Will get back to this next weekend. Not available at the moment.
hi @yihou I made some change on the workflow, that "break" your PR, can you please rebase your branch? |
sorry for the late reply, I have resolved conflicts and use |
@yihou sorry you will hate me. I made some change (better check on node version and add support to AndroidStudio). Can you update your PR, and then I will merge it |
Just merged. You may have a look now. |
merged ! and thanks again! |
No description provided.