Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: ISSUE #171 #172

Merged
merged 2 commits into from
Dec 2, 2020
Merged

REF: ISSUE #171 #172

merged 2 commits into from
Dec 2, 2020

Conversation

abbasegbeyemi
Copy link
Contributor

The file action was having issues opening project paths that contain spaces in the path name. This properly escapes the project paths. Also used changed the functions backticks`` to $().

The fix was made to the info.plist file directly. I don't know if that file is auto generated, but I could not find anywhere else to implement the fix. Thanks.

When using a file action to open a project path which contains a space in it. The pycharm cannot open it because spaces in paths are not properly escaped.

This fix uses sed to properly escape spaces in file paths.
Changed <= back to &lt;=
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bchatard
Copy link
Owner

bchatard commented Dec 2, 2020

hi @abbasegbeyemi

thanks for this PR. Since I did not use this feature I will trust your work :)

@bchatard bchatard merged commit b8ab093 into bchatard:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants