-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other connection row advanced details #829
Conversation
Deployment URLs ready for review. |
4431305
to
0560caf
Compare
0560caf
to
a922dfe
Compare
I think more information is better as long as it doesn't cause to much confusion/clutter for end users. So I agree this make be too much in production. Code looks good though 👍 |
Yeah I'm considering whether any of those expanders that show JSON all over the app should be developer flag hidden in production. So agree it's something to think about hiding in the not too far future. |
a922dfe
to
cb24f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! 👍🏻
Regarding hiding the functionality in production: I actually think it might be useful there more than anywhere to troubleshoot. Connections in particular is read/write in production as well to allow for OOB interactions, so this is great.
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
cb24f7f
to
c494c06
Compare
Lets make debugging some issues (and getting details about established connections) a lot quicker. Call additional connection details when digging into a Connection row.
This stuff could be hidden with the developer flag if we'd prefer once there's production usage.
Should help with
Examples: