Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other connection row advanced details #829

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

loneil
Copy link
Collaborator

@loneil loneil commented Sep 21, 2023

Lets make debugging some issues (and getting details about established connections) a lot quicker. Call additional connection details when digging into a Connection row.

  • Endpoints
  • Metadata

This stuff could be hidden with the developer flag if we'd prefer once there's production usage.

Should help with

  • Mediator testing
  • Endorser connection checking
  • Other service endpoint issues

Examples:


image


image


image


image

@loneil loneil temporarily deployed to development September 21, 2023 18:55 — with GitHub Actions Inactive
@loneil loneil force-pushed the feature/tenantUiAdditionalConnetionCalls branch from 4431305 to 0560caf Compare September 21, 2023 19:08
@loneil loneil temporarily deployed to development September 21, 2023 19:11 — with GitHub Actions Inactive
@loneil loneil force-pushed the feature/tenantUiAdditionalConnetionCalls branch from 0560caf to a922dfe Compare September 21, 2023 19:44
@jamshale
Copy link
Collaborator

I think more information is better as long as it doesn't cause to much confusion/clutter for end users. So I agree this make be too much in production.

Code looks good though 👍

@loneil loneil temporarily deployed to development September 21, 2023 19:49 — with GitHub Actions Inactive
@loneil
Copy link
Collaborator Author

loneil commented Sep 21, 2023

Yeah I'm considering whether any of those expanders that show JSON all over the app should be developer flag hidden in production. So agree it's something to think about hiding in the not too far future.

@loneil loneil force-pushed the feature/tenantUiAdditionalConnetionCalls branch from a922dfe to cb24f7f Compare September 21, 2023 19:53
@loneil loneil temporarily deployed to development September 21, 2023 19:58 — with GitHub Actions Inactive
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 👍🏻
Regarding hiding the functionality in production: I actually think it might be useful there more than anywhere to troubleshoot. Connections in particular is read/write in production as well to allow for OOB interactions, so this is great.

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil force-pushed the feature/tenantUiAdditionalConnetionCalls branch from cb24f7f to c494c06 Compare September 21, 2023 20:45
@loneil loneil temporarily deployed to development September 21, 2023 20:49 — with GitHub Actions Inactive
@loneil loneil merged commit 9a23ac2 into main Sep 21, 2023
11 checks passed
@loneil loneil temporarily deployed to development September 21, 2023 21:44 — with GitHub Actions Inactive
@esune esune deleted the feature/tenantUiAdditionalConnetionCalls branch September 21, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants