Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip reservation password entry for auto-approve and check in automatically #606

Merged
merged 3 commits into from
May 26, 2023

Conversation

loneil
Copy link
Collaborator

@loneil loneil commented May 26, 2023

NOTE: In this PR, auto-approve is on, can undo flag setting before merge

Bypass reservation ID and PW if the reservation PW comes back to the Tenant UI (IE, auto-approve is on).
Just call check-in with the returned details. Some view changing to handle this flow. Tested it out with auto on and auto off and working fine.
Skips sending the email with the reservation ID and PW since the user has no concept of those in this case. The Wallet ID and Key are handled all the same as before.

image

image

image

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil temporarily deployed to development May 26, 2023 00:06 — with GitHub Actions Inactive
@github-actions
Copy link

Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil temporarily deployed to development May 26, 2023 00:20 — with GitHub Actions Inactive
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil temporarily deployed to development May 26, 2023 00:47 — with GitHub Actions Inactive
@loneil loneil changed the title Skip reservation stuff and check in automatically Skip reservation password entry for auto-approve and check in automatically May 26, 2023
@loneil loneil requested review from esune and swcurran May 26, 2023 00:53
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@esune esune merged commit c100043 into develop May 26, 2023
@esune esune deleted the feature/autoPresentWallet branch May 26, 2023 08:52
@esune esune temporarily deployed to development May 26, 2023 08:52 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants