Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Dependabot file to support Python , Javascipt, Typescript, Vue , devcontainer and docker packages #1072

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

rajpalc7
Copy link
Contributor

No description provided.

@rajpalc7 rajpalc7 marked this pull request as draft April 12, 2024 21:19
@rajpalc7 rajpalc7 force-pushed the dependabot branch 3 times, most recently from 9296ee6 to 6917952 Compare April 12, 2024 23:04
@rajpalc7 rajpalc7 closed this Apr 12, 2024
@rajpalc7 rajpalc7 reopened this Apr 15, 2024
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary:

  • It appears you've included a number of folders that do not contain any dependency manifests.
  • You are still missing several folders that do contain dependency manifests or files that dependabot can update.
  • You've included a number of folders that do not exist in the project.
  • Some of the issues with the PR appear to be related with the fact that you are working with an outdated copy of the code.
  • Your first step should be to update your working copy to the latest version of the code.

image

image

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
@rajpalc7
Copy link
Contributor Author

Hi @WadeBarnes , this is ready to review now

.github/dependabot.yml Outdated Show resolved Hide resolved
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajpalc7, Along with the issue below, I noticed you're still missing an update section for one supported package-ecosystem.

.github/dependabot.yml Outdated Show resolved Hide resolved
@rajpalc7
Copy link
Contributor Author

Thanks @WadeBarnes , I have updated the missing section now. Will wait for akiff to comment on this for final review.

WadeBarnes
WadeBarnes previously approved these changes Apr 18, 2024
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We just need to wait to here back from @amanji regarding the question from @loneil.

@amanji
Copy link
Collaborator

amanji commented Apr 18, 2024

I've now move the LOB demo out of the services. See #1074

@WadeBarnes
Copy link
Member

@rajpalc7, @amanji's PR has been merged, you can update your work here as needed.

…ript, Vue , devcontainer and docker packages

Signed-off-by: Rajpal Chauhan <rajpal.chauhan@gov.bc.ca>
@rajpalc7
Copy link
Contributor Author

Hi @WadeBarnes , I have updated my work according to changes.

@WadeBarnes WadeBarnes merged commit d93fcf8 into bcgov:main Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants