-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile page Endorser DID registration handling #1052
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment URLs ready for review. |
loneil
commented
Apr 9, 2024
loneil
changed the title
Profile page DID handling
Profile page Endorser DID registration handling
Apr 9, 2024
loneil
force-pushed
the
feature/tenantUiEndorseDidHandling
branch
from
April 9, 2024 21:07
279b850
to
60132d4
Compare
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
force-pushed
the
feature/tenantUiEndorseDidHandling
branch
from
April 10, 2024 20:46
60132d4
to
ba1265d
Compare
jamshale
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the Register DID function on the Tenant UI Profile page to cover additional Endorser governance processes we use for BC Gov Traction.
Need to split the Register DID (depending on use case) steps into multiple asynchronous as the Endorser will have to multiple manual steps in some cases. Add additional checks and handling to move on to the next step automatically for various auto-endorsement cases.
So with the existing cases, these governance setups are supported in the Tenant UI.
I think we should possibly make documentation/videos showing how all these options work...
Case 1: "Auto-everything" Endorser
Case 2: Approve Connection, set connection to auto endorse
Case 3: Approve Connection, set DID in allow list
In order for the Tenant UI Profile page to know the DID registration is In Progress in case 3 it needs to scan through it's pending author transactions (likely always just the 1 going for Tenant setup) to see which "candidate DID" the tenant communicates to the Endorser.