Remove bcovrin-dev, set second (aliased) bcovrin-test for local multiledger #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
loneil
requested review from
swcurran,
i5okie,
esune,
amanji,
Gavinok and
WadeBarnes
|
Tagged a bunch of people on this in case anyone has any thoughts/opinions/gotchas they can think of. |
Deployment URLs ready for review. |
esune
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As bcovrin-dev is deprecated we can't use it any more in Traction. So handle that in a couple ways
Deployments'
For dev and PR deployments just remove BCovrin-dev as an option. These have other combos of candy and sovrin so they have other ledgers as well as bcovrin-test.
Default helm values
Just remove bcovrin-dev, leave only bcovrin-test.
Default helm is overridden everywhere we use it and there's the dev and pr examples in here of how to specify multiple ledgers if someone needs them.
Local Docker
We do want multiple ledgers on local dev for multi-ledger development and tenant UI development.
Not going to use candy or sovrin on local dev. We stand up 2 local endorser instances in the docker environment, so just have each of those using the same ledger (bcovrin-test), but alias the IDs and endorser details differently so it's interpreted as "multiple" ledgers.
Replace bcovrin-dev with "bcovrin-test-1" (all endorser setup is "endorser-1" etc etc, so keep that convention).
Tried this out locally and it's working as expected.