Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StamenTonerLight replaced by BC Gov basemaps #107

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

michaelpnelson
Copy link
Contributor

This complements changes in bcgov/smk#236. Again, the basemap name may change, but almost all the functionality is in this change. (TODO: update package.json to require SMK minimum version 1.2.0 - this needs to wait for SMK 1.2.0 to be released.)

@michaelpnelson michaelpnelson self-assigned this Oct 20, 2023
Copy link
Contributor

@dgboss dgboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion...in config-viewer.js, change the default value of the configViewerBaseMap getter from Topographic to BCGov.

@michaelpnelson
Copy link
Contributor Author

One suggestion...in config-viewer.js, change the default value of the configViewerBaseMap getter from Topographic to BCGov.

Thanks, Darren. This is addressed in the new commit.

@michaelpnelson michaelpnelson merged commit 02f7419 into master Oct 24, 2023
@michaelpnelson michaelpnelson deleted the bc_basemap_squashed1 branch October 24, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants