22061, 21522 - EFT shortname history #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short Name history integrate with new short name history refactor / Hook up reverse payment
|
Need API updates merged before merging this one |
ochiu
commented
Aug 1, 2024
| @@ -250,32 +250,32 @@ export default defineComponent({ | |||
| { | |||
| col: 'linkedAccount', | |||
| hasFilter: false, | |||
| minWidth: '200px', | |||
| width: '200px', | |||
There was a problem hiding this comment.
UX wants alignment of columns of the link table and payment history table. Set width to get it as close as possible
|
seeker25
reviewed
Aug 7, 2024
| 'accountBranch': null, | ||
| 'accountId': null, | ||
| 'accountName': null, | ||
| 'accountBranch': 'Sushi Division', |
There was a problem hiding this comment.
Where is the Noodle Division?
There was a problem hiding this comment.
I am leveling that up right now :) one day
seeker25
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#22061
bcgov/entity#21522
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).